Tag Go memstats during writes to _internal #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
runtime_not_tagged
branch
from
54e2fc4 to
07bcd52
Compare
| @@ -241,6 +241,12 @@ func (m *Monitor) Statistics(tags map[string]string) ([]*statistic, error) { | |||
| Tags: make(map[string]string), | |||
| Values: make(map[string]interface{}), | |||
| } | |||
|
|
|||
| // Add any supplied tags to Go memstats | |||
| for k, v := range tags { | |||
There was a problem hiding this comment.
See line 162 to see where the "supplied tags" come from.
|
+1 |
otoolep
added a commit
that referenced
this pull request
Sep 18, 2015
Tag Go memstats during writes to _internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go runtime stats were not being tagged when written to the
_internaldatabase, where meant there was no way to get stats for just a single node -- data for all nodes was returned in aggregate, if the system was being run as a cluster. This change fixes that.Before the change:
After the change: